Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a9f184f0 authored by Sukadev Bhattiprolu's avatar Sukadev Bhattiprolu Committed by Al Viro
Browse files

devpts: Must release s_umount on error 



We should drop the ->s_umount mutex if an error occurs after the
sget()/grab_super() call. This was introduced when adding support
for multiple instances of devpts and noticed during a code review/reorg.

Signed-off-by: default avatarSukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent af5df566

fs/devpts/inode.c

+2 −0
Original line number Diff line number Diff line
@@ -385,6 +385,7 @@ static int new_pts_mount(struct file_system_type *fs_type, int flags, 


fail:

	dput(mnt->mnt_sb->s_root);

	up_write(&mnt->mnt_sb->s_umount);

	deactivate_super(mnt->mnt_sb);

	return err;

}
@@ -473,6 +474,7 @@ static int init_pts_mount(struct file_system_type *fs_type, int flags, 
	err = mknod_ptmx(mnt->mnt_sb);

	if (err) {

		dput(mnt->mnt_sb->s_root);

		up_write(&mnt->mnt_sb->s_umount);

		deactivate_super(mnt->mnt_sb);

	}