Commit a9eec556 authored Aug 31, 2006 by Corey Minyard Committed by Linus Torvalds Sep 01, 2006

[PATCH] IPMI: fix occasional oops on module unload



Olaf Kirch of SuSE tracked down a problem where module unloads of the IPMI
driver would occasionally result in Oopses.  He tracked that down to a
variable that wasn't always initialized properly in some situations.  This
patch initializes that variable.  Olaf sent a patch that kzalloc-ed the
data, but this structure is large enough that I would perfer to not do
that.  Thanks Olaf!

Signed-off-by: Corey Minyard <minyard@acm.org>
Cc: Olaf Kirch <okir@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 43a1dd50

drivers/char/ipmi/ipmi_msghandler.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -3428,6 +3428,7 @@ struct ipmi_recv_msg *ipmi_alloc_recv_msg(void)

		rv = kmalloc(sizeof(struct ipmi_recv_msg), GFP_ATOMIC);
		if (rv) {
		rv->user = NULL;
		rv->done = free_recv_msg;
		atomic_inc(&recv_msg_inuse_count);
		}