Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a9a3cac6 authored by Julia Lawall's avatar Julia Lawall Committed by Tomi Valkeinen
Browse files

video: fbdev: sis: delete double assignment 

Delete successive assignments to the same location.  The second assignment
is changed to update a different field, as done in other nearby code.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression i;
@@

*i = ...;
 i = ...;
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 2079a513

drivers/video/fbdev/sis/init301.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1714,7 +1714,7 @@ SiS_GetLCDResInfo(struct SiS_Private *SiS_Pr, unsigned short ModeNo, unsigned sh 
			       SiS_Pr->PanelVCLKIdx315 = VCLK81_315; /* ? */

			       SiS_Pr->PanelVCLKIdx315 = VCLK81_315; /* ? */

			    } else {

			    } else {

			       SiS_Pr->PanelHT   = 1688; SiS_Pr->PanelVT   =  802;

			       SiS_Pr->PanelHT   = 1688; SiS_Pr->PanelVT   =  802;

			       SiS_Pr->PanelHRS  =   48; SiS_Pr->PanelHRS  =  112;

			       SiS_Pr->PanelHRS  =   48; SiS_Pr->PanelHRE  =  112;

			       SiS_Pr->PanelVRS  =    3; SiS_Pr->PanelVRE  =    6;

			       SiS_Pr->PanelVRS  =    3; SiS_Pr->PanelVRE  =    6;

			       SiS_Pr->PanelVCLKIdx300 = VCLK81_300;

			       SiS_Pr->PanelVCLKIdx300 = VCLK81_300;

			       SiS_Pr->PanelVCLKIdx315 = VCLK81_315;

			       SiS_Pr->PanelVCLKIdx315 = VCLK81_315;