Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a99ebec1 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Simon Horman
Browse files

sh-pfc: Remove check for impossible error condition 



The pfc pointer can't be NULL in the get and set value functions, remove
the error check.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: default avatarPaul Mundt <lethal@linux-sh.org>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarSimon Horman <horms+renesas@verge.net.au>
parent 4a2e0d18

drivers/sh/pfc/gpio.c

+2 −2
Original line number Diff line number Diff line
@@ -52,7 +52,7 @@ static void sh_gpio_set_value(struct sh_pfc *pfc, unsigned gpio, int value) 
	struct pinmux_data_reg *dr = NULL;

	int bit = 0;



	if (!pfc || sh_pfc_get_data_reg(pfc, gpio, &dr, &bit) != 0)

	if (sh_pfc_get_data_reg(pfc, gpio, &dr, &bit) != 0)

		BUG();

	else

		sh_pfc_write_bit(dr, bit, value);
@@ -63,7 +63,7 @@ static int sh_gpio_get_value(struct sh_pfc *pfc, unsigned gpio) 
	struct pinmux_data_reg *dr = NULL;

	int bit = 0;



	if (!pfc || sh_pfc_get_data_reg(pfc, gpio, &dr, &bit) != 0)

	if (sh_pfc_get_data_reg(pfc, gpio, &dr, &bit) != 0)

		return -EINVAL;



	return sh_pfc_read_bit(dr, bit);