Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a93e20a8 authored by Dan Carpenter's avatar Dan Carpenter Committed by Konrad Rzeszutek Wilk
Browse files

xen-gntdev: unlock on error path in gntdev_mmap() 



We should unlock here and also decrement the number of &map->users.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
parent 12f0258d

drivers/xen/gntdev.c

+3 −1
Original line number Original line Diff line number Diff line
@@ -662,7 +662,7 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma) 
	if (map->flags) {

	if (map->flags) {

		if ((vma->vm_flags & VM_WRITE) &&

		if ((vma->vm_flags & VM_WRITE) &&

				(map->flags & GNTMAP_readonly))

				(map->flags & GNTMAP_readonly))

			return -EINVAL;

			goto out_unlock_put;

	} else {

	} else {

		map->flags = GNTMAP_host_map;

		map->flags = GNTMAP_host_map;

		if (!(vma->vm_flags & VM_WRITE))

		if (!(vma->vm_flags & VM_WRITE))
@@ -700,6 +700,8 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma) 
	spin_unlock(&priv->lock);

	spin_unlock(&priv->lock);

	return err;

	return err;





out_unlock_put:

	spin_unlock(&priv->lock);

out_put_map:

out_put_map:

	if (use_ptemod)

	if (use_ptemod)

		map->vma = NULL;

		map->vma = NULL;