Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a920ff41 authored by Jean Delvare's avatar Jean Delvare Committed by Jean Delvare
Browse files

i2c: Improve deprecation warnings 



When warning on the use of deprecated i2c_driver methods
attach_adapter and detach_adapter, mention the name of the driver
which needs to be updated.

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
parent d733ed6c

drivers/i2c/i2c-core.c

+4 −2
Original line number Original line Diff line number Diff line
@@ -797,7 +797,8 @@ static int i2c_do_add_adapter(struct i2c_driver *driver, 




	/* Let legacy drivers scan this bus for matching devices */

	/* Let legacy drivers scan this bus for matching devices */

	if (driver->attach_adapter) {

	if (driver->attach_adapter) {

		dev_warn(&adap->dev, "attach_adapter method is deprecated\n");

		dev_warn(&adap->dev, "%s: attach_adapter method is deprecated\n",

			 driver->driver.name);

		dev_warn(&adap->dev, "Please use another way to instantiate "

		dev_warn(&adap->dev, "Please use another way to instantiate "

			 "your i2c_client\n");

			 "your i2c_client\n");

		/* We ignore the return code; if it fails, too bad */

		/* We ignore the return code; if it fails, too bad */
@@ -984,7 +985,8 @@ static int i2c_do_del_adapter(struct i2c_driver *driver, 




	if (!driver->detach_adapter)

	if (!driver->detach_adapter)

		return 0;

		return 0;

	dev_warn(&adapter->dev, "detach_adapter method is deprecated\n");

	dev_warn(&adapter->dev, "%s: detach_adapter method is deprecated\n",

		 driver->driver.name);

	res = driver->detach_adapter(adapter);

	res = driver->detach_adapter(adapter);

	if (res)

	if (res)

		dev_err(&adapter->dev, "detach_adapter failed (%d) "

		dev_err(&adapter->dev, "detach_adapter failed (%d) "