Commit a886f7f4 authored Apr 03, 2013 by Arend van Spriel Committed by John W. Linville Apr 03, 2013

brcmfmac: correct success flag passed by brcmf_sdbrcm_txpkt()



The function brcmf_sdbrcm_txpkt() calls brcmf_txcomplete() with
a parameter success. For this parameter it passes ret != 0, but
that condition is true upon failure.

Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: Piotr Haber <phaber@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 2a2ac756

drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1897,7 +1897,7 @@ static int brcmf_sdbrcm_txpkt(struct brcmf_sdio bus, struct sk_buff pkt,
		done:
		/* restore pkt buffer pointer before calling tx complete routine */
		skb_pull(pkt, SDPCM_HDRLEN + pad);
		brcmf_txcomplete(bus->sdiodev->dev, pkt, ret != 0);
		brcmf_txcomplete(bus->sdiodev->dev, pkt, ret == 0);
		return ret;
		}