Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a8712105 authored by Johannes Berg's avatar Johannes Berg
Browse files

mac80211: remove IEEE80211_KEY_FLAG_WMM_STA 



There's no driver using this flag, so it seems
that all drivers support HW crypto with WMM or
don't support it at all. Remove the flag and
code setting it.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 153a5fc4

include/net/mac80211.h

+0 −3
Original line number Diff line number Diff line
@@ -1101,8 +1101,6 @@ static inline bool ieee80211_vif_is_mesh(struct ieee80211_vif *vif) 
 * These flags are used for communication about keys between the driver

 * and mac80211, with the @flags parameter of &struct ieee80211_key_conf.

 *

 * @IEEE80211_KEY_FLAG_WMM_STA: Set by mac80211, this flag indicates

 *	that the STA this key will be used with could be using QoS.

 * @IEEE80211_KEY_FLAG_GENERATE_IV: This flag should be set by the

 *	driver to indicate that it requires IV generation for this

 *	particular key.
@@ -1127,7 +1125,6 @@ static inline bool ieee80211_vif_is_mesh(struct ieee80211_vif *vif) 
 *	%IEEE80211_KEY_FLAG_SW_MGMT_TX flag to encrypt such frames in SW.

 */

enum ieee80211_key_flags {

	IEEE80211_KEY_FLAG_WMM_STA	= 1<<0,

	IEEE80211_KEY_FLAG_GENERATE_IV	= 1<<1,

	IEEE80211_KEY_FLAG_GENERATE_MMIC= 1<<2,

	IEEE80211_KEY_FLAG_PAIRWISE	= 1<<3,

net/mac80211/key.c

+0 −26
Original line number Diff line number Diff line
@@ -440,32 +440,6 @@ int ieee80211_key_link(struct ieee80211_key *key, 
	key->sdata = sdata;

	key->sta = sta;



	if (sta) {

		/*

		 * some hardware cannot handle TKIP with QoS, so

		 * we indicate whether QoS could be in use.

		 */

		if (test_sta_flag(sta, WLAN_STA_WME))

			key->conf.flags |= IEEE80211_KEY_FLAG_WMM_STA;

	} else {

		if (sdata->vif.type == NL80211_IFTYPE_STATION) {

			struct sta_info *ap;



			/*

			 * We're getting a sta pointer in, so must be under

			 * appropriate locking for sta_info_get().

			 */



			/* same here, the AP could be using QoS */

			ap = sta_info_get(key->sdata, key->sdata->u.mgd.bssid);

			if (ap) {

				if (test_sta_flag(ap, WLAN_STA_WME))

					key->conf.flags |=

						IEEE80211_KEY_FLAG_WMM_STA;

			}

		}

	}



	mutex_lock(&sdata->local->key_mtx);



	if (sta && pairwise)