Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a81c0f07 authored by Julia Lawall's avatar Julia Lawall Committed by Brian Norris
Browse files

mtd: nand: sunxi: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr

):

// <smpl>
@@
expression root,e;
local idexpression child;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
(
   return child;
|
+  of_node_put(child);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Acked-by: default avatarChen-Yu Tsai <wens@csie.org>
Acked-by: default avatarBoris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
parent 081976bc
Loading
Loading
Loading
Loading
+3 −1
Original line number Diff line number Diff line
@@ -1391,9 +1391,11 @@ static int sunxi_nand_chips_init(struct device *dev, struct sunxi_nfc *nfc)

	for_each_child_of_node(np, nand_np) {
		ret = sunxi_nand_chip_init(dev, nfc, nand_np);
		if (ret)
		if (ret) {
			of_node_put(nand_np);
			return ret;
		}
	}

	return 0;
}