Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a76ff847 authored by Vladis Dronov's avatar Vladis Dronov Committed by Greg Kroah-Hartman
Browse files

drm/vmwgfx: limit the number of mip levels in vmw_gb_surface_define_ioctl() 

commit ee9c4e681ec4f58e42a83cb0c22a0289ade1aacf upstream.

The 'req->mip_levels' parameter in vmw_gb_surface_define_ioctl() is
a user-controlled 'uint32_t' value which is used as a loop count limit.
This can lead to a kernel lockup and DoS. Add check for 'req->mip_levels'.

References:
https://bugzilla.redhat.com/show_bug.cgi?id=1437431



Signed-off-by: default avatarVladis Dronov <vdronov@redhat.com>
Reviewed-by: default avatarSinclair Yeh <syeh@vmware.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 64c21af5

drivers/gpu/drm/vmwgfx/vmwgfx_surface.c

+3 −0
Original line number Diff line number Diff line
@@ -1280,6 +1280,9 @@ int vmw_gb_surface_define_ioctl(struct drm_device *dev, void *data, 
	if (req->multisample_count != 0)

		return -EINVAL;



	if (req->mip_levels > DRM_VMW_MAX_MIP_LEVELS)

		return -EINVAL;



	if (unlikely(vmw_user_surface_size == 0))

		vmw_user_surface_size = ttm_round_pot(sizeof(*user_srf)) +

			128;