Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a70e407f authored by Tushar Dave's avatar Tushar Dave Committed by Jeff Kirsher
Browse files

i40e: Fix errors resulted while turning off TSO 



On systems with 128 CPUs, turning off TSO results in errors,

i40e 0000:03:00.0: failed to get tracking for 1 vectors for VSI 400, err=-12
i40e 0000:03:00.0: Couldn't create FDir VSI
i40e 0000:03:00.0: i40e_ptp_init: PTP not supported on eth0
i40e 0000:03:00.0: couldn't add VEB, err I40E_ERR_ADMIN_QUEUE_ERROR aq_err I40E_AQ_RC_ENOENT
i40e 0000:03:00.0: rebuild of switch failed: -1, will try to set up simple PF connection
i40e 0000:03:00.0 eth0: adding 00:10:e0:8a:24:b6 vid=0

Enabling FD_SB without checking availability of MSI-X vector is the
root cause. This change adds necessary check.

Signed-off-by: default avatarTushar Dave <tushar.n.dave@oracle.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 07061958

drivers/net/ethernet/intel/i40e/i40e.h

+1 −0
Original line number Diff line number Diff line
@@ -283,6 +283,7 @@ struct i40e_pf { 
#endif /* I40E_FCOE */

	u16 num_lan_qps;           /* num lan queues this PF has set up */

	u16 num_lan_msix;          /* num queue vectors for the base PF vsi */

	u16 num_fdsb_msix;         /* num queue vectors for sideband Fdir */

	u16 num_iwarp_msix;        /* num of iwarp vectors for this PF */

	int iwarp_base_vector;

	int queues_left;           /* queues left unclaimed */

drivers/net/ethernet/intel/i40e/i40e_main.c

+6 −2
Original line number Diff line number Diff line
@@ -7185,7 +7185,7 @@ static int i40e_set_num_rings_in_vsi(struct i40e_vsi *vsi) 
		vsi->alloc_queue_pairs = 1;

		vsi->num_desc = ALIGN(I40E_FDIR_RING_COUNT,

				      I40E_REQ_DESCRIPTOR_MULTIPLE);

		vsi->num_q_vectors = 1;

		vsi->num_q_vectors = pf->num_fdsb_msix;

		break;



	case I40E_VSI_VMDQ2:
@@ -7569,9 +7569,11 @@ static int i40e_init_msix(struct i40e_pf *pf) 
	/* reserve one vector for sideband flow director */

	if (pf->flags & I40E_FLAG_FD_SB_ENABLED) {

		if (vectors_left) {

			pf->num_fdsb_msix = 1;

			v_budget++;

			vectors_left--;

		} else {

			pf->num_fdsb_msix = 0;

			pf->flags &= ~I40E_FLAG_FD_SB_ENABLED;

		}

	}
@@ -8590,6 +8592,8 @@ bool i40e_set_ntuple(struct i40e_pf *pf, netdev_features_t features) 
		/* Enable filters and mark for reset */

		if (!(pf->flags & I40E_FLAG_FD_SB_ENABLED))

			need_reset = true;

		/* enable FD_SB only if there is MSI-X vector */

		if (pf->num_fdsb_msix > 0)

			pf->flags |= I40E_FLAG_FD_SB_ENABLED;

	} else {

		/* turn off filters, mark for reset and clear SW filter list */