Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a70948b5 authored by Julien Brunel's avatar Julien Brunel Committed by Artem Bityutskiy
Browse files

UBIFS: use an IS_ERR test rather than a NULL test 

In case of error, the function kthread_create returns an ERR pointer,
but never returns a NULL pointer. So a NULL test that comes before an
IS_ERR test should be deleted.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/

)

// <smpl>
@match_bad_null_test@
expression x, E;
statement S1,S2;
@@
x = kthread_create(...)
... when != x = E
* if (x == NULL)
S1 else S2
// </smpl>

Signed-off-by: default avatarJulien Brunel <brunel@diku.dk>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
parent 746103ac

fs/ubifs/super.c

+0 −4
Original line number Diff line number Diff line
@@ -1032,8 +1032,6 @@ static int mount_ubifs(struct ubifs_info *c) 


		/* Create background thread */

		c->bgt = kthread_create(ubifs_bg_thread, c, c->bgt_name);

		if (!c->bgt)

			c->bgt = ERR_PTR(-EINVAL);

		if (IS_ERR(c->bgt)) {

			err = PTR_ERR(c->bgt);

			c->bgt = NULL;
@@ -1347,8 +1345,6 @@ static int ubifs_remount_rw(struct ubifs_info *c) 


	/* Create background thread */

	c->bgt = kthread_create(ubifs_bg_thread, c, c->bgt_name);

	if (!c->bgt)

		c->bgt = ERR_PTR(-EINVAL);

	if (IS_ERR(c->bgt)) {

		err = PTR_ERR(c->bgt);

		c->bgt = NULL;