Commit a67911d3 authored Jun 26, 2016 by Markus Elfring Committed by Lee Jones Jun 29, 2016

mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child()



The platform_device_put() function was called in one case by the
add_numbered_child() function during error handling even if the passed
variable "pdev" contained a null pointer.
Return directly in this case.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

parent d347792c

drivers/mfd/twl-core.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -622,11 +622,8 @@ add_numbered_child(unsigned mod_no, const char *name, int num,
		twl = &twl_priv->twl_modules[sid];

		pdev = platform_device_alloc(name, num);
		if (!pdev) {
		dev_dbg(&twl->client->dev, "can't alloc dev\n");
		status = -ENOMEM;
		goto err;
		}
		if (!pdev)
		return ERR_PTR(-ENOMEM);

		pdev->dev.parent = &twl->client->dev;