Commit a558690b authored Dec 12, 2020 by Christophe JAILLET Committed by Greg Kroah-Hartman Dec 29, 2020

net: bcmgenet: Fix a resource leak in an error handling path in the probe functin



[ Upstream commit 4375ada01963d1ebf733d60d1bb6e5db401e1ac6 ]

If the 'register_netdev()' call fails, we must undo a previous
'bcmgenet_mii_init()' call.

Fixes: 1c1008c7 ("net: bcmgenet: add main driver file")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20201212182005.120437-1-christophe.jaillet@wanadoo.fr


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 1ccbd404

drivers/net/ethernet/broadcom/genet/bcmgenet.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -3433,8 +3433,10 @@ static int bcmgenet_probe(struct platform_device *pdev)
	clk_disable_unprepare(priv->clk);		clk_disable_unprepare(priv->clk);

	err = register_netdev(dev);		err = register_netdev(dev);
	if (err)		if (err) {
			bcmgenet_mii_exit(dev);
	goto err;		goto err;
			}

	return err;		return err;