Commit a534dc52 authored Nov 16, 2015 by Sabrina Dubroca Committed by David S. Miller Nov 17, 2015

ipvlan: fix use after free of skb



ipvlan_handle_frame is a rx_handler, and when it returns a value other
than RX_HANDLER_CONSUMED (here, NET_RX_DROP aka RX_HANDLER_ANOTHER),
__netif_receive_skb_core expects that the skb still exists and will
process it further, but we just freed it.

Fixes: 2ad7bf36 ("ipvlan: Initial check-in of the IPVLAN driver.")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent cf554ada

drivers/net/ipvlan/ipvlan_core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -653,5 +653,5 @@ rx_handler_result_t ipvlan_handle_frame(struct sk_buff **pskb)
		WARN_ONCE(true, "ipvlan_handle_frame() called for mode = [%hx]\n",
		port->mode);
		kfree_skb(skb);
		return NET_RX_DROP;
		return RX_HANDLER_CONSUMED;
		}