Commit a506e7b4 authored Apr 18, 2013 by nikolay@redhat.com Committed by David S. Miller Apr 19, 2013

bonding: vlans don't get deleted on enslave failure



The main problem is with vid refcount which only gets bumped up.
Delete the vlans after err_detach as that's the first error path
after the vlans are added.

Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 25e40305

drivers/net/bonding/bond_main.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1906,6 +1906,7 @@ int bond_enslave(struct net_device bond_dev, struct net_device slave_dev)
		bond_mc_list_flush(bond_dev, slave_dev);
		netif_addr_unlock_bh(bond_dev);
		}
		bond_del_vlans_from_slave(bond, slave_dev);
		write_lock_bh(&bond->lock);
		bond_detach_slave(bond, new_slave);
		write_unlock_bh(&bond->lock);