Commit a4f54ec4 authored Sep 15, 2017 by tangwenji Committed by Greg Kroah-Hartman Dec 20, 2017

iscsi-target: fix memory leak in lio_target_tiqn_addtpg()




[ Upstream commit 12d5a43b2dffb6cd28062b4e19024f7982393288 ]

tpg must free when call core_tpg_register() return fail

Signed-off-by: tangwenji <tang.wenji@zte.com.cn>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e086a82a

drivers/target/iscsi/iscsi_target_configfs.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1144,7 +1144,7 @@ static struct se_portal_group *lio_target_tiqn_addtpg(

		ret = core_tpg_register(wwn, &tpg->tpg_se_tpg, SCSI_PROTOCOL_ISCSI);
		if (ret < 0)
		return NULL;
		goto free_out;

		ret = iscsit_tpg_add_portal_group(tiqn, tpg);
		if (ret != 0)
		@@ -1156,6 +1156,7 @@ static struct se_portal_group *lio_target_tiqn_addtpg(
		return &tpg->tpg_se_tpg;
		out:
		core_tpg_deregister(&tpg->tpg_se_tpg);
		free_out:
		kfree(tpg);
		return NULL;
		}