Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a4887ea5 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: idmouse: fix NULL-deref at probe 



commit b0addd3fa6bcd119be9428996d5d4522479ab240 upstream.

Make sure to check the number of endpoints to avoid dereferencing a
NULL-pointer should a malicious device lack endpoints.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 21e0621e

drivers/usb/misc/idmouse.c

+3 −0
Original line number Diff line number Diff line
@@ -346,6 +346,9 @@ static int idmouse_probe(struct usb_interface *interface, 
	if (iface_desc->desc.bInterfaceClass != 0x0A)

		return -ENODEV;



	if (iface_desc->desc.bNumEndpoints < 1)

		return -ENODEV;



	/* allocate memory for our device state and initialize it */

	dev = kzalloc(sizeof(*dev), GFP_KERNEL);

	if (dev == NULL)