Commit a3d1c9bc authored Mar 14, 2019 by Kangjie Lu Committed by Greg Kroah-Hartman May 04, 2019

scsi: qla4xxx: fix a potential NULL pointer dereference



[ Upstream commit fba1bdd2a9a93f3e2181ec1936a3c2f6b37e7ed6 ]

In case iscsi_lookup_endpoint fails, the fix returns -EINVAL to avoid NULL
pointer dereference.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org>

parent 9842f4ce

drivers/scsi/qla4xxx/ql4_os.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -3207,6 +3207,8 @@ static int qla4xxx_conn_bind(struct iscsi_cls_session *cls_session,
		if (iscsi_conn_bind(cls_session, cls_conn, is_leading))
		return -EINVAL;
		ep = iscsi_lookup_endpoint(transport_fd);
		if (!ep)
		return -EINVAL;
		conn = cls_conn->dd_data;
		qla_conn = conn->dd_data;
		qla_conn->qla_ep = ep->dd_data;