Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a38ae37f authored by kashyap.desai@lsi.com's avatar kashyap.desai@lsi.com Committed by James Bottomley
Browse files

[SCSI] mptfusion: Avoid out of order Event processing due to cpu migration 



Driver will now schedule MPI event using "delay_work_queue_on" to
specify same CPU to be used to schedule work.  Earlier it used
"delay_work_queue" which can cause migration of work due to kernel'
timer migration feature.

Signed-off-by: default avatarKashyap Desai <kashyap.desai@lsi.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent e62cca19

drivers/message/fusion/mptsas.c

+9 −7
Original line number Diff line number Diff line
@@ -290,10 +290,11 @@ mptsas_add_fw_event(MPT_ADAPTER *ioc, struct fw_event_work *fw_event, 
	spin_lock_irqsave(&ioc->fw_event_lock, flags);

	list_add_tail(&fw_event->list, &ioc->fw_event_list);

	INIT_DELAYED_WORK(&fw_event->work, mptsas_firmware_event_work);

	devtprintk(ioc, printk(MYIOC_s_DEBUG_FMT "%s: add (fw_event=0x%p)\n",

	    ioc->name, __func__, fw_event));

	queue_delayed_work(ioc->fw_event_q, &fw_event->work,

	    delay);

	devtprintk(ioc, printk(MYIOC_s_DEBUG_FMT "%s: add (fw_event=0x%p)"

		"on cpuid %d\n", ioc->name, __func__,

		fw_event, smp_processor_id()));

	queue_delayed_work_on(smp_processor_id(), ioc->fw_event_q,

	    &fw_event->work, delay);

	spin_unlock_irqrestore(&ioc->fw_event_lock, flags);

}
@@ -305,10 +306,11 @@ mptsas_requeue_fw_event(MPT_ADAPTER *ioc, struct fw_event_work *fw_event, 
	unsigned long flags;

	spin_lock_irqsave(&ioc->fw_event_lock, flags);

	devtprintk(ioc, printk(MYIOC_s_DEBUG_FMT "%s: reschedule task "

	    "(fw_event=0x%p)\n", ioc->name, __func__, fw_event));

	    "(fw_event=0x%p)on cpuid %d\n", ioc->name, __func__,

		fw_event, smp_processor_id()));

	fw_event->retries++;

	queue_delayed_work(ioc->fw_event_q, &fw_event->work,

	    msecs_to_jiffies(delay));

	queue_delayed_work_on(smp_processor_id(), ioc->fw_event_q,

	    &fw_event->work, msecs_to_jiffies(delay));

	spin_unlock_irqrestore(&ioc->fw_event_lock, flags);

}