Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a29d1260 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Alex Deucher
Browse files

drm/amdgpu/powerplay/smu7: fix unintialized data usage 



A recent bugfix replaced an out-of-bounds access with direct
use of unintialized data:

drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c: In function 'smu7_patch_limits_vddc':
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2033:6: error: 'vddc' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2146:11: note: 'vddc' was declared here
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2033:6: error: 'vddci' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2146:17: note: 'vddci' was declared here
  uint32_t vddc, vddci;

This initializes the data as before using the correct type.

Fixes: 77f7f71f ("drm/amdgpu/powerplay/smu7: fix static checker warning")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 757124d9

drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c

+2 −0
Original line number Diff line number Diff line
@@ -2133,9 +2133,11 @@ static int smu7_patch_limits_vddc(struct pp_hwmgr *hwmgr, 
	struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);



	if (tab) {

		vddc = tab->vddc;

		smu7_patch_ppt_v0_with_vdd_leakage(hwmgr, &vddc,

						   &data->vddc_leakage);

		tab->vddc = vddc;

		vddci = tab->vddci;

		smu7_patch_ppt_v0_with_vdd_leakage(hwmgr, &vddci,

						   &data->vddci_leakage);

		tab->vddci = vddci;