Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a28e4b2b authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead 



Removing unnecessary static buffers is good.
Use the vsprintf %pV extension instead.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarMikulas Patocka <mikulas@twibright.com>
Cc: stable@vger.kernel.org      # v2.6.36+
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent ce657611

fs/hpfs/super.c

+7 −4
Original line number Original line Diff line number Diff line
@@ -52,17 +52,20 @@ static void unmark_dirty(struct super_block *s) 
}

}





/* Filesystem error... */

/* Filesystem error... */

static char err_buf[1024];



void hpfs_error(struct super_block *s, const char *fmt, ...)

void hpfs_error(struct super_block *s, const char *fmt, ...)

{

{

	struct va_format vaf;

	va_list args;

	va_list args;





	va_start(args, fmt);

	va_start(args, fmt);

	vsnprintf(err_buf, sizeof(err_buf), fmt, args);



	vaf.fmt = fmt;

	vaf.va = &args;



	pr_err("filesystem error: %pV", &vaf);



	va_end(args);

	va_end(args);





	pr_err("filesystem error: %s", err_buf);

	if (!hpfs_sb(s)->sb_was_error) {

	if (!hpfs_sb(s)->sb_was_error) {

		if (hpfs_sb(s)->sb_err == 2) {

		if (hpfs_sb(s)->sb_err == 2) {

			pr_cont("; crashing the system because you wanted it\n");

			pr_cont("; crashing the system because you wanted it\n");