Commit a2773e0f authored Dec 17, 2018 by Dan Carpenter Committed by Greg Kroah-Hartman Dec 05, 2019

IB/qib: Fix an error code in qib_sdma_verbs_send()



[ Upstream commit 5050ae5fa3d54c8e83e1e447cc7e3591110a7f57 ]

We accidentally return success on this error path.

Fixes: f931551b ("IB/qib: Add new qib driver for QLogic PCIe InfiniBand adapters")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent e5610903

drivers/infiniband/hw/qib/qib_sdma.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -600,8 +600,10 @@ int qib_sdma_verbs_send(struct qib_pportdata *ppd,
		dw = (len + 3) >> 2;
		addr = dma_map_single(&ppd->dd->pcidev->dev, sge->vaddr,
		dw << 2, DMA_TO_DEVICE);
		if (dma_mapping_error(&ppd->dd->pcidev->dev, addr))
		if (dma_mapping_error(&ppd->dd->pcidev->dev, addr)) {
		ret = -ENOMEM;
		goto unmap;
		}
		sdmadesc[0] = 0;
		make_sdma_desc(ppd, sdmadesc, (u64) addr, dw, dwoffset);
		/* SDmaUseLargeBuf has to be set in every descriptor */