Commit a1dcbd11 authored Apr 13, 2016 by Eric Anholt Committed by Marc Zyngier May 11, 2016

irqchip/bcm2836: Use a more generic memory barrier call



dsb() requires an argument on arm64, so we needed to add "sy".
Instead, take this opportunity to switch to the same smp_wmb() call
that gic uses for its IPIs.  This is a less strong barrier than we
were doing before (dmb(ishst) compared to dsb(sy)), but it seems to be
the correct one.

Signed-off-by: Eric Anholt <eric@anholt.net>
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>

parent cb290d82

drivers/irqchip/irq-bcm2836.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -195,7 +195,7 @@ static void bcm2836_arm_irqchip_send_ipi(const struct cpumask *mask,
		* Ensure that stores to normal memory are visible to the
		* other CPUs before issuing the IPI.
		*/
		dsb();
		smp_wmb();

		for_each_cpu(cpu, mask) {
		writel(1 << ipi, mailbox0_base + 16 * cpu);