Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a114a9d6 authored by Christian Borntraeger's avatar Christian Borntraeger Committed by Martin Schwidefsky
Browse files

[S390] vmcp: remove BKL 



The vmcp driver uses the session->mutex for concurrent access of the data
structures. Therefore, the BKL in vmcp_open does not protect against any
other function in the driver.
The BLK in vmcp_open would protect concurrent access to the module init
but all necessary steps ave finished before misc_register is called.
We can safely remove the lock_kernel from vcmp.

Signed-off-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent f414f5f1

drivers/s390/char/vmcp.c

+0 −3
Original line number Diff line number Diff line
@@ -16,7 +16,6 @@ 
#include <linux/kernel.h>

#include <linux/miscdevice.h>

#include <linux/module.h>

#include <linux/smp_lock.h>

#include <asm/cpcmd.h>

#include <asm/debug.h>

#include <asm/uaccess.h>
@@ -41,13 +40,11 @@ static int vmcp_open(struct inode *inode, struct file *file) 
	if (!session)

		return -ENOMEM;



	lock_kernel();

	session->bufsize = PAGE_SIZE;

	session->response = NULL;

	session->resp_size = 0;

	mutex_init(&session->mutex);

	file->private_data = session;

	unlock_kernel();

	return nonseekable_open(inode, file);

}