Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a0fd1efd authored by Kyungmin Park's avatar Kyungmin Park Committed by Artem Bityutskiy
Browse files

UBI: fix buffer padding 



Instead of correctly pad the buffer wich we are writing to the
eraseblock during update, we used weird construct:

memset(buf + len, 0xFF, len - len);

Fix this.

Signed-off-by: default avatarKyungmin Park <kmpark@infradead.org>
Signed-off-by: default avatarArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
parent beeea636

drivers/mtd/ubi/upd.c

+3 −3
Original line number Diff line number Diff line
@@ -237,10 +237,10 @@ static int write_leb(struct ubi_device *ubi, struct ubi_volume *vol, int lnum, 
	int err;



	if (vol->vol_type == UBI_DYNAMIC_VOLUME) {

		len = ALIGN(len, ubi->min_io_size);

		memset(buf + len, 0xFF, len - len);

		int l = ALIGN(len, ubi->min_io_size);



		len = ubi_calc_data_len(ubi, buf, len);

		memset(buf + len, 0xFF, l - len);

		len = ubi_calc_data_len(ubi, buf, l);

		if (len == 0) {

			dbg_msg("all %d bytes contain 0xFF - skip", len);

			return 0;