Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a0d5c04c authored by Will Deacon's avatar Will Deacon
Browse files

iommu/arm-smmu: Handle unknown CERROR values gracefully 



Whilst the architecture only defines a few of the possible CERROR values,
we should handle unknown values gracefully rather than go out of bounds
trying to print out an error description.

Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
parent 9a4a9d8c

drivers/iommu/arm-smmu-v3.c

+5 −3
Original line number Diff line number Diff line
@@ -857,15 +857,17 @@ static void arm_smmu_cmdq_skip_err(struct arm_smmu_device *smmu) 
	};



	dev_err(smmu->dev, "CMDQ error (cons 0x%08x): %s\n", cons,

		cerror_str[idx]);

		idx < ARRAY_SIZE(cerror_str) ?  cerror_str[idx] : "Unknown");



	switch (idx) {

	case CMDQ_ERR_CERROR_ILL_IDX:

		break;

	case CMDQ_ERR_CERROR_ABT_IDX:

		dev_err(smmu->dev, "retrying command fetch\n");

	case CMDQ_ERR_CERROR_NONE_IDX:

		return;

	case CMDQ_ERR_CERROR_ILL_IDX:

		/* Fallthrough */

	default:

		break;

	}



	/*