Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a06a5bb9 authored by Dave Jiang's avatar Dave Jiang Committed by Vinod Koul
Browse files

dmaengine: timb_dma: convert callback to helper function 



This is in preperation of moving to a callback that provides results to the
callback for the transaction. The conversion will maintain current behavior
and the driver must convert to new callback mechanism at a later time in
order to receive results.

Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
Reviewed-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 370c0446

drivers/dma/timb_dma.c

+3 −6
Original line number Diff line number Diff line
@@ -226,8 +226,7 @@ static void __td_start_dma(struct timb_dma_chan *td_chan) 


static void __td_finish(struct timb_dma_chan *td_chan)

{

	dma_async_tx_callback		callback;

	void				*param;

	struct dmaengine_desc_callback	cb;

	struct dma_async_tx_descriptor	*txd;

	struct timb_dma_desc		*td_desc;
@@ -252,8 +251,7 @@ static void __td_finish(struct timb_dma_chan *td_chan) 
	dma_cookie_complete(txd);

	td_chan->ongoing = false;



	callback = txd->callback;

	param = txd->callback_param;

	dmaengine_desc_get_callback(txd, &cb);



	list_move(&td_desc->desc_node, &td_chan->free_list);
@@ -262,8 +260,7 @@ static void __td_finish(struct timb_dma_chan *td_chan) 
	 * The API requires that no submissions are done from a

	 * callback, so we don't need to drop the lock here

	 */

	if (callback)

		callback(param);

	dmaengine_desc_callback_invoke(&cb, NULL);

}



static u32 __td_ier_mask(struct timb_dma *td)