Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a05d4845 authored by Thanneeru Srinivasulu's avatar Thanneeru Srinivasulu Committed by David S. Miller
Browse files

net, thunderx: Add TX timeout and RX buffer alloc failure stats. 



When system is low on atomic memory, too many error messages are logged.
Since this is not a total failure but a simple switch to non-atomic allocation
better to have a stat.

Also add a stat for reset, kicked due to transmit watchdog timeout.

Signed-off-by: default avatarThanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
Signed-off-by: default avatarSunil Goutham <sgoutham@cavium.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 65411adb

drivers/net/ethernet/cavium/thunder/nic.h

+3 −0
Original line number Diff line number Diff line
@@ -248,10 +248,13 @@ struct nicvf_drv_stats { 
	u64 rx_frames_jumbo;

	u64 rx_drops;



	u64 rcv_buffer_alloc_failures;



	/* Tx */

	u64 tx_frames_ok;

	u64 tx_drops;

	u64 tx_tso;

	u64 tx_timeout;

	u64 txq_stop;

	u64 txq_wake;

};

drivers/net/ethernet/cavium/thunder/nicvf_ethtool.c

+2 −0
Original line number Diff line number Diff line
@@ -89,9 +89,11 @@ static const struct nicvf_stat nicvf_drv_stats[] = { 
	NICVF_DRV_STAT(rx_frames_1518),

	NICVF_DRV_STAT(rx_frames_jumbo),

	NICVF_DRV_STAT(rx_drops),

	NICVF_DRV_STAT(rcv_buffer_alloc_failures),

	NICVF_DRV_STAT(tx_frames_ok),

	NICVF_DRV_STAT(tx_tso),

	NICVF_DRV_STAT(tx_drops),

	NICVF_DRV_STAT(tx_timeout),

	NICVF_DRV_STAT(txq_stop),

	NICVF_DRV_STAT(txq_wake),

};

drivers/net/ethernet/cavium/thunder/nicvf_main.c

+1 −0
Original line number Diff line number Diff line
@@ -1394,6 +1394,7 @@ static void nicvf_tx_timeout(struct net_device *dev) 
		netdev_warn(dev, "%s: Transmit timed out, resetting\n",

			    dev->name);



	nic->drv_stats.tx_timeout++;

	schedule_work(&nic->reset_task);

}

drivers/net/ethernet/cavium/thunder/nicvf_queues.c

+1 −2
Original line number Diff line number Diff line
@@ -96,8 +96,7 @@ static inline int nicvf_alloc_rcv_buffer(struct nicvf *nic, gfp_t gfp, 
		nic->rb_page = alloc_pages(gfp | __GFP_COMP | __GFP_NOWARN,

					   order);

		if (!nic->rb_page) {

			netdev_err(nic->netdev,

				   "Failed to allocate new rcv buffer\n");

			nic->drv_stats.rcv_buffer_alloc_failures++;

			return -ENOMEM;

		}

		nic->rb_page_offset = 0;