Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9ffd906d authored by Dan Carpenter's avatar Dan Carpenter Committed by Wim Van Sebroeck
Browse files

watchdog: mtk_wdt: signedness bug in mtk_wdt_start() 



"ret" should be signed for the error handling to work correctly.  This
doesn't matter much in real life since mtk_wdt_set_timeout() always
succeeds.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarMatthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
parent 3c435c1e

drivers/watchdog/mtk_wdt.c

+1 −1
Original line number Diff line number Diff line
@@ -133,7 +133,7 @@ static int mtk_wdt_start(struct watchdog_device *wdt_dev) 
	u32 reg;

	struct mtk_wdt_dev *mtk_wdt = watchdog_get_drvdata(wdt_dev);

	void __iomem *wdt_base = mtk_wdt->wdt_base;

	u32 ret;

	int ret;



	ret = mtk_wdt_set_timeout(wdt_dev, wdt_dev->timeout);

	if (ret < 0)