Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9fdc723a authored by Dan Carpenter's avatar Dan Carpenter Committed by John W. Linville
Browse files

ipw2x00: clean up a condition 



The original condition was "(PAGE_SIZE - len)" when "(len < PAGE_SIZE)"
is intended.

This condition is not really sufficient, but also not really needed...
If "len > PAGE_SIZE" then it we will print a warning message in dmesg
but there are no other effects.  Maybe we should just remove the
condition?

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 2aa01652

drivers/net/wireless/ipw2x00/ipw2200.c

+1 −1
Original line number Diff line number Diff line
@@ -1363,7 +1363,7 @@ static ssize_t show_cmd_log(struct device *d, 
	if (!priv->cmdlog)

		return 0;

	for (i = (priv->cmdlog_pos + 1) % priv->cmdlog_len;

	     (i != priv->cmdlog_pos) && (PAGE_SIZE - len);

	     (i != priv->cmdlog_pos) && (len < PAGE_SIZE);

	     i = (i + 1) % priv->cmdlog_len) {

		len +=

		    snprintf(buf + len, PAGE_SIZE - len,