Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9fd3d3a4 authored by Edward Cree's avatar Edward Cree Committed by David S. Miller
Browse files

sfc: don't BUG_ON efx->max_channels == 0 in probe 



efx_ef10_probe() was BUGging out if the BAR2 size was 0.  This is
 unnecessarily violent; instead we should just fail to probe the device.
Kept a WARN_ON as this problem indicates a broken or misconfigured NIC.

Signed-off-by: default avatarEdward Cree <ecree@solarflare.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c495d648

drivers/net/ethernet/sfc/ef10.c

+2 −1
Original line number Diff line number Diff line
@@ -180,7 +180,8 @@ static int efx_ef10_probe(struct efx_nic *efx) 
		      EFX_MAX_CHANNELS,

		      resource_size(&efx->pci_dev->resource[EFX_MEM_BAR]) /

		      (EFX_VI_PAGE_SIZE * EFX_TXQ_TYPES));

	BUG_ON(efx->max_channels == 0);

	if (WARN_ON(efx->max_channels == 0))

		return -EIO;



	nic_data = kzalloc(sizeof(*nic_data), GFP_KERNEL);

	if (!nic_data)