Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f67675a authored by Jingoo Han's avatar Jingoo Han Committed by Linus Torvalds
Browse files

backlight: locomolcd: fix checkpatch error and warning



This patch fixes the checkpatch error and warning as below:

  WARNING: space prohibited between function name and open parenthesis '('
  ERROR: trailing statements should be on next line

Also, long comments are fixed for the preferred style and unnecessary
lines are removed.

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent ae664dba
Loading
Loading
Loading
Loading
+25 −13
Original line number Diff line number Diff line
@@ -107,7 +107,6 @@ void locomolcd_power(int on)
}
EXPORT_SYMBOL(locomolcd_power);


static int current_intensity;

static int locomolcd_set_intensity(struct backlight_device *bd)
@@ -122,13 +121,25 @@ static int locomolcd_set_intensity(struct backlight_device *bd)
		intensity = 0;

	switch (intensity) {
	/* AC and non-AC are handled differently, but produce same results in sharp code? */
	case 0: locomo_frontlight_set(locomolcd_dev, 0, 0, 161); break;
	case 1: locomo_frontlight_set(locomolcd_dev, 117, 0, 161); break;
	case 2: locomo_frontlight_set(locomolcd_dev, 163, 0, 148); break;
	case 3: locomo_frontlight_set(locomolcd_dev, 194, 0, 161); break;
	case 4: locomo_frontlight_set(locomolcd_dev, 194, 1, 161); break;

	/*
	 * AC and non-AC are handled differently,
	 * but produce same results in sharp code?
	 */
	case 0:
		locomo_frontlight_set(locomolcd_dev, 0, 0, 161);
		break;
	case 1:
		locomo_frontlight_set(locomolcd_dev, 117, 0, 161);
		break;
	case 2:
		locomo_frontlight_set(locomolcd_dev, 163, 0, 148);
		break;
	case 3:
		locomo_frontlight_set(locomolcd_dev, 194, 0, 161);
		break;
	case 4:
		locomo_frontlight_set(locomolcd_dev, 194, 1, 161);
		break;
	default:
		return -ENODEV;
	}
@@ -175,9 +186,11 @@ static int locomolcd_probe(struct locomo_dev *ldev)

	locomo_gpio_set_dir(ldev->dev.parent, LOCOMO_GPIO_FL_VR, 0);

	/* the poodle_lcd_power function is called for the first time
	/*
	 * the poodle_lcd_power function is called for the first time
	 * from fs_initcall, which is before locomo is activated.
	 * We need to recall poodle_lcd_power here*/
	 * We need to recall poodle_lcd_power here
	 */
	if (machine_is_poodle())
		locomolcd_power(1);

@@ -226,7 +239,6 @@ static struct locomo_driver poodle_lcd_driver = {
	.resume = locomolcd_resume,
};


static int __init locomolcd_init(void)
{
	return locomo_driver_register(&poodle_lcd_driver);