Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9ecf51c5 authored by Hante Meuleman's avatar Hante Meuleman Committed by John W. Linville
Browse files

brcmfmac: Fix hex dump for FWIL. 



The debug function brcmf_dbg_hex_dump API got changed and the
information string should preferably contain a \n at the end
of the string. Update the FWIL so debug output looks better.

Reviewed-by: default avatarArend Van Spriel <arend@broadcom.com>
Reviewed-by: default avatarFranky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: default avatarPieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: default avatarHante Meuleman <meuleman@broadcom.com>
Signed-off-by: default avatarArend van Spriel <arend@broadcom.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 8141083c

drivers/net/wireless/brcm80211/brcmfmac/fwil.c

+6 −6
Original line number Diff line number Diff line
@@ -68,7 +68,7 @@ brcmf_fil_cmd_data_set(struct brcmf_if *ifp, u32 cmd, void *data, u32 len) 


	brcmf_dbg(FIL, "cmd=%d, len=%d\n", cmd, len);

	brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data,

			   min_t(uint, len, MAX_HEX_DUMP_LEN), "data");

			   min_t(uint, len, MAX_HEX_DUMP_LEN), "data\n");



	err = brcmf_fil_cmd_data(ifp, cmd, data, len, true);

	mutex_unlock(&ifp->drvr->proto_block);
@@ -86,7 +86,7 @@ brcmf_fil_cmd_data_get(struct brcmf_if *ifp, u32 cmd, void *data, u32 len) 


	brcmf_dbg(FIL, "cmd=%d, len=%d\n", cmd, len);

	brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data,

			   min_t(uint, len, MAX_HEX_DUMP_LEN), "data");

			   min_t(uint, len, MAX_HEX_DUMP_LEN), "data\n");



	mutex_unlock(&ifp->drvr->proto_block);
@@ -155,7 +155,7 @@ brcmf_fil_iovar_data_set(struct brcmf_if *ifp, char *name, void *data, 


	brcmf_dbg(FIL, "name=%s, len=%d\n", name, len);

	brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data,

			   min_t(uint, len, MAX_HEX_DUMP_LEN), "data");

			   min_t(uint, len, MAX_HEX_DUMP_LEN), "data\n");



	buflen = brcmf_create_iovar(name, data, len, drvr->proto_buf,

				    sizeof(drvr->proto_buf));
@@ -195,7 +195,7 @@ brcmf_fil_iovar_data_get(struct brcmf_if *ifp, char *name, void *data, 


	brcmf_dbg(FIL, "name=%s, len=%d\n", name, len);

	brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data,

			   min_t(uint, len, MAX_HEX_DUMP_LEN), "data");

			   min_t(uint, len, MAX_HEX_DUMP_LEN), "data\n");



	mutex_unlock(&drvr->proto_block);

	return err;
@@ -278,7 +278,7 @@ brcmf_fil_bsscfg_data_set(struct brcmf_if *ifp, char *name, 


	brcmf_dbg(FIL, "bssidx=%d, name=%s, len=%d\n", ifp->bssidx, name, len);

	brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data,

			   min_t(uint, len, MAX_HEX_DUMP_LEN), "data");

			   min_t(uint, len, MAX_HEX_DUMP_LEN), "data\n");



	buflen = brcmf_create_bsscfg(ifp->bssidx, name, data, len,

				     drvr->proto_buf, sizeof(drvr->proto_buf));
@@ -317,7 +317,7 @@ brcmf_fil_bsscfg_data_get(struct brcmf_if *ifp, char *name, 
	}

	brcmf_dbg(FIL, "bssidx=%d, name=%s, len=%d\n", ifp->bssidx, name, len);

	brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data,

			   min_t(uint, len, MAX_HEX_DUMP_LEN), "data");

			   min_t(uint, len, MAX_HEX_DUMP_LEN), "data\n");



	mutex_unlock(&drvr->proto_block);

	return err;