Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9e6ab1b7 authored by Quinn Tran's avatar Quinn Tran Committed by Greg Kroah-Hartman
Browse files

scsi: qla2xxx: Fix incorrect reporting of task management failure 

commit 58ca5999e0367d131de82a75257fbfd5aed0195d upstream.

User experienced no task management error while target device is responding
with error. The RSP_CODE field in the status IOCB is in little endian.
Driver assumes it's big endian and it picked up erroneous data.

Convert the data back to big endian as is on the wire.

Link: https://lore.kernel.org/r/20220310092604.22950-2-njavali@marvell.com


Fixes: faef62d1 ("[SCSI] qla2xxx: Fix Task Management command asynchronous handling")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: default avatarQuinn Tran <qutran@marvell.com>
Signed-off-by: default avatarNilesh Javali <njavali@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fdbc5cd0

drivers/scsi/qla2xxx/qla_isr.c

+1 −0
Original line number Diff line number Diff line
@@ -1618,6 +1618,7 @@ qla24xx_tm_iocb_entry(scsi_qla_host_t *vha, struct req_que *req, void *tsk) 
		iocb->u.tmf.data = QLA_FUNCTION_FAILED;

	} else if ((le16_to_cpu(sts->scsi_status) &

	    SS_RESPONSE_INFO_LEN_VALID)) {

		host_to_fcp_swap(sts->data, sizeof(sts->data));

		if (le32_to_cpu(sts->rsp_data_len) < 4) {

			ql_log(ql_log_warn, fcport->vha, 0x503b,

			    "Async-%s error - hdl=%x not enough response(%d).\n",