Commit 9dd8d5f8 authored Jul 19, 2016 by Arnd Bergmann Committed by Wim Van Sebroeck Jul 25, 2016

Documentation/watchdog: check return value for magic close

A recent commit added a write to the watchdog test code for doing the "magic
close", but that caused a compile-time warning:

Documentation/watchdog/src/watchdog-test.c: In function ‘main’:
Documentation/watchdog/src/watchdog-test.c:94:5: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result]

This changes the code to print a runtime warning if the write fails.

Fixes: 5a2d3de1 ("Documentation/watchdog: add support for magic close to watchdog-test")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Timur Tabi <timur@codeaurora.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>

parent e035d8f7

Documentation/watchdog/src/watchdog-test.c

+11 −3

Original line number	Diff line number	Diff line
		@@ -2,6 +2,7 @@
		* Watchdog Driver Test Program
		*/

		#include <errno.h>
		#include <stdio.h>
		#include <stdlib.h>
		#include <string.h>
		@@ -35,8 +36,12 @@ static void keep_alive(void)

		static void term(int sig)
		{
		write(fd, &v, 1);
		int ret = write(fd, &v, 1);

		close(fd);
		if (ret < 0)
		printf("\nStopping watchdog ticks failed (%d)...\n", errno);
		else
		printf("\nStopping watchdog ticks...\n");
		exit(0);
		}
		@@ -45,6 +50,7 @@ int main(int argc, char *argv[])
		{
		int flags;
		unsigned int ping_rate = 1;
		int ret;

		setbuf(stdout, NULL);

		@@ -91,7 +97,9 @@ int main(int argc, char *argv[])
		sleep(ping_rate);
		}
		end:
		write(fd, &v, 1);
		ret = write(fd, &v, 1);
		if (ret < 0)
		printf("Stopping watchdog ticks failed (%d)...\n", errno);
		close(fd);
		return 0;
		}