Commit 9d031d94 authored May 23, 2011 by Shahar Lev Committed by Greg Kroah-Hartman Jun 07, 2011

drivers:misc: ti-st: fix skipping of change remote baud



Before the incrementing of ptr in skip_change_remote_baud,
it points to cur_action, but the increment is done by
the size of nxt_action instead. This could cause ptr
to not point to a bts_action structure, which is
harmful for the increment of ptr done in download_firmware.
Therefore, the skipping is first done for cur_action.

Signed-off-by: Shahar Lev <shahar@wizery.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent bb2b43fe

drivers/misc/ti-st/st_kim.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -245,9 +245,9 @@ void skip_change_remote_baud(unsigned char *ptr, long len)
		pr_err("invalid action after change remote baud command");
		} else {
		ptr = ptr + sizeof(struct bts_action) +
		((struct bts_action *)nxt_action)->size;
		((struct bts_action *)cur_action)->size;
		len = len - (sizeof(struct bts_action) +
		((struct bts_action *)nxt_action)->size);
		((struct bts_action *)cur_action)->size);
		/* warn user on not commenting these in firmware */
		pr_warn("skipping the wait event of change remote baud");
		}