Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9cf3b5fa authored by Linus Walleij's avatar Linus Walleij
Browse files

rtc: fix coh901331 startup crash 



The rtc_device_register() call has changed semantics so that it
will immediately call out to rtc_read_alarm() and since the
callbacks require the drvdata to be set, we need to set it before
the registration call to avoid NULL dereference.

Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent cf568c58

drivers/rtc/rtc-coh901331.c

+2 −2
Original line number Diff line number Diff line
@@ -220,6 +220,7 @@ static int __init coh901331_probe(struct platform_device *pdev) 
	}

	clk_disable(rtap->clk);



	platform_set_drvdata(pdev, rtap);

	rtap->rtc = rtc_device_register("coh901331", &pdev->dev, &coh901331_ops,

					 THIS_MODULE);

	if (IS_ERR(rtap->rtc)) {
@@ -227,11 +228,10 @@ static int __init coh901331_probe(struct platform_device *pdev) 
		goto out_no_rtc;

	}



	platform_set_drvdata(pdev, rtap);



	return 0;



 out_no_rtc:

	platform_set_drvdata(pdev, NULL);

 out_no_clk_enable:

	clk_put(rtap->clk);

 out_no_clk: