Commit 9cb627d5 authored Sep 01, 2010 by Li Zefan Committed by Ingo Molnar Sep 09, 2010

perf, trace: Fix module leak



Commit 1c024eca (perf, trace: Optimize tracepoints by using
per-tracepoint-per-cpu hlist to track events) caused a module
refcount leak.

Reported-And-Tested-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <4C7E1F12.8030304@cn.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent da34634f

kernel/trace/trace_event_perf.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -91,6 +91,8 @@ int perf_trace_init(struct perf_event *p_event)
		tp_event->class && tp_event->class->reg &&
		try_module_get(tp_event->mod)) {
		ret = perf_trace_event_init(tp_event, p_event);
		if (ret)
		module_put(tp_event->mod);
		break;
		}
		}
		@@ -146,6 +148,7 @@ void perf_trace_destroy(struct perf_event *p_event)
		}
		}
		out:
		module_put(tp_event->mod);
		mutex_unlock(&event_mutex);
		}