Commit 9cb4c5b9 authored Dec 28, 2021 by Jiasheng Jiang Committed by Greg Kroah-Hartman Jan 27, 2022

ASoC: samsung: idma: Check of ioremap return value



[ Upstream commit 3ecb46755eb85456b459a1a9f952c52986bce8ec ]

Because of the potential failure of the ioremap(), the buf->area could
be NULL.
Therefore, we need to check it and return -ENOMEM in order to transfer
the error.

Fixes: f09aecd5 ("ASoC: SAMSUNG: Add I2S0 internal dma driver")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Link: https://lore.kernel.org/r/20211228034026.1659385-1-jiasheng@iscas.ac.cn


Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 76b9517e

sound/soc/samsung/idma.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -369,6 +369,8 @@ static int preallocate_idma_buffer(struct snd_pcm *pcm, int stream)
	buf->addr = idma.lp_tx_addr;		buf->addr = idma.lp_tx_addr;
	buf->bytes = idma_hardware.buffer_bytes_max;		buf->bytes = idma_hardware.buffer_bytes_max;
	buf->area = (unsigned char * __force)ioremap(buf->addr, buf->bytes);		buf->area = (unsigned char * __force)ioremap(buf->addr, buf->bytes);
			if (!buf->area)
			return -ENOMEM;

	return 0;		return 0;
	}		}