Commit 9c6acc11 authored Oct 17, 2017 by Dhaval Patel

drm/msm/sde: validate qseed3 configuration on each frame update



A client updates the qseed3 configuration through property
and it updates the plane configuration through separate
property. It may possible that client update source and destination
rectangle property but does not update the qseed3 configuration
property. Current sde driver does not validate the combined
configuration in those cases and may lead to hang in qseed3
hardware block due to stale programming. This patch forces
the qseed3 property atomic check for each kickoff.

Change-Id: Ibf11683232175ecea86e8f2d99c8ef75fd98e90d
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>

parent 1ded649b

drivers/gpu/drm/msm/sde/sde_plane.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -3057,8 +3057,9 @@ static int _sde_plane_validate_scaler_v2(struct sde_plane *psde,
		return -EINVAL;
		}

		/* don't run checks unless scaler data was changed */
		if (pstate->scaler_check_state != SDE_PLANE_SCLCHECK_SCALER_V2_CHECK)
		if (psde->debugfs_default_scale \|\|
		(pstate->scaler_check_state != SDE_PLANE_SCLCHECK_SCALER_V2 &&
		pstate->scaler_check_state != SDE_PLANE_SCLCHECK_SCALER_V2_CHECK))
		return 0;

		pstate->scaler_check_state = SDE_PLANE_SCLCHECK_INVALID;