Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9c52a1e7 authored by Wen Yang's avatar Wen Yang Committed by Greg Kroah-Hartman
Browse files

media: exynos4-is: fix leaked of_node references 



[ Upstream commit da79bf41a4d170ca93cc8f3881a70d734a071c37 ]

The call to of_get_child_by_name returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
drivers/media/platform/exynos4-is/fimc-is.c:813:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 807, but without a corresponding object release within this function.
drivers/media/platform/exynos4-is/fimc-is.c:870:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 807, but without a corresponding object release within this function.
drivers/media/platform/exynos4-is/fimc-is.c:885:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 807, but without a corresponding object release within this function.
drivers/media/platform/exynos4-is/media-dev.c:545:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 541, but without a corresponding object release within this function.
drivers/media/platform/exynos4-is/media-dev.c:528:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 499, but without a corresponding object release within this function.
drivers/media/platform/exynos4-is/media-dev.c:534:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 499, but without a corresponding object release within this function.

Signed-off-by: default avatarWen Yang <wen.yang99@zte.com.cn>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 870b141f

drivers/media/platform/exynos4-is/fimc-is.c

+1 −0
Original line number Diff line number Diff line
@@ -819,6 +819,7 @@ static int fimc_is_probe(struct platform_device *pdev) 
		return -ENODEV;



	is->pmu_regs = of_iomap(node, 0);

	of_node_put(node);

	if (!is->pmu_regs)

		return -ENOMEM;

drivers/media/platform/exynos4-is/media-dev.c

+2 −0
Original line number Diff line number Diff line
@@ -494,6 +494,7 @@ static int fimc_md_register_sensor_entities(struct fimc_md *fmd) 
			continue;



		ret = fimc_md_parse_port_node(fmd, port, index);

		of_node_put(port);

		if (ret < 0) {

			of_node_put(node);

			goto rpm_put;
@@ -527,6 +528,7 @@ static int __of_get_csis_id(struct device_node *np) 
	if (!np)

		return -EINVAL;

	of_property_read_u32(np, "reg", &reg);

	of_node_put(np);

	return reg - FIMC_INPUT_MIPI_CSI2_0;

}