Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9ae97a89 authored by Jayachandran C's avatar Jayachandran C Committed by Wolfram Sang
Browse files

i2c: i2c-ocores: DT bindings and minor fixes. 



Cleanups to i2c-cores, no change in logic, changes are:
* Move i2c-ocores device tree documentation from source file to
  Documentation/devicetree/bindings/i2c/i2c-ocores.txt.
* Add \n to dev_warn and dev_err messages where missing
* Minor updates to the text and formatting fixes.

Signed-off-by: default avatarJayachandran C <jayachandranc@netlogicmicro.com>
Signed-off-by: default avatarWolfram Sang <w.sang@pengutronix.de>
parent 097df403

Documentation/devicetree/bindings/i2c/i2c-ocores.txt

0 → 100644
+27 −0
Original line number Diff line number Diff line 
Device tree configuration for i2c-ocores



Required properties:

- compatible      : "opencores,i2c-ocores"

- reg             : bus address start and address range size of device

- interrupts      : interrupt number

- regstep         : size of device registers in bytes

- clock-frequency : frequency of bus clock in Hz

- #address-cells  : should be <1>

- #size-cells     : should be <0>



Example:



	i2c0: ocores@a0000000 {

		#address-cells = <1>;

		#size-cells = <0>;

		compatible = "opencores,i2c-ocores";

		reg = <0xa0000000 0x8>;

		interrupts = <10>;

		regstep = <1>;

		clock-frequency = <20000000>;



		dummy@60 {

			compatible = "dummy";

			reg = <0x60>;

		};

	};

drivers/i2c/busses/i2c-ocores.c

+7 −38
Original line number Diff line number Diff line
@@ -10,40 +10,9 @@ 
 */



/*

 * Device tree configuration:

 *

 * Required properties:

 * - compatible      : "opencores,i2c-ocores"

 * - reg             : bus address start and address range size of device

 * - interrupts      : interrupt number

 * - regstep         : size of device registers in bytes

 * - clock-frequency : frequency of bus clock in Hz

 * 

 * Example:

 *

 *  i2c0: ocores@a0000000 {

 *              compatible = "opencores,i2c-ocores";

 *              reg = <0xa0000000 0x8>;

 *              interrupts = <10>;

 *

 *              regstep = <1>;

 *              clock-frequency = <20000000>;

 *

 * -- Devices connected on this I2C bus get

 * -- defined here; address- and size-cells

 * -- apply to these child devices

 *

 *              #address-cells = <1>;

 *              #size-cells = <0>;

 *

 *              dummy@60 {

 *                     compatible = "dummy";

 *                     reg = <60>;

 *              };

 *  };

 *

 * This driver can be used from the device tree, see

 *     Documentation/devicetree/bindings/i2c/ocore-i2c.txt

 */



#include <linux/kernel.h>

#include <linux/module.h>

#include <linux/init.h>
@@ -254,7 +223,7 @@ static int ocores_i2c_of_probe(struct platform_device* pdev, 


	val = of_get_property(pdev->dev.of_node, "regstep", NULL);

	if (!val) {

		dev_err(&pdev->dev, "Missing required parameter 'regstep'");

		dev_err(&pdev->dev, "Missing required parameter 'regstep'\n");

		return -ENODEV;

	}

	i2c->regstep = be32_to_cpup(val);
@@ -262,7 +231,7 @@ static int ocores_i2c_of_probe(struct platform_device* pdev, 
	val = of_get_property(pdev->dev.of_node, "clock-frequency", NULL);

	if (!val) {

		dev_err(&pdev->dev,

			"Missing required parameter 'clock-frequency'");

			"Missing required parameter 'clock-frequency'\n");

		return -ENODEV;

	}

	i2c->clock_khz = be32_to_cpup(val) / 1000;