Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9aa0c0e6 authored by Mikulas Patocka's avatar Mikulas Patocka Committed by Alasdair G Kergon
Browse files

dm snapshot: optimize track_chunk 



track_chunk is always called with interrupts enabled. Consequently, we
do not need to save and restore interrupt state in "flags" variable.
This patch changes spin_lock_irqsave to spin_lock_irq and
spin_unlock_irqrestore to spin_unlock_irq.

Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
Signed-off-by: default avatarAlasdair G Kergon <agk@redhat.com>
parent 19cbbc60

drivers/md/dm-snap.c

+2 −3
Original line number Diff line number Diff line
@@ -198,14 +198,13 @@ static struct dm_snap_tracked_chunk *track_chunk(struct dm_snapshot *s, 
{

	struct dm_snap_tracked_chunk *c = mempool_alloc(s->tracked_chunk_pool,

							GFP_NOIO);

	unsigned long flags;



	c->chunk = chunk;



	spin_lock_irqsave(&s->tracked_chunk_lock, flags);

	spin_lock_irq(&s->tracked_chunk_lock);

	hlist_add_head(&c->node,

		       &s->tracked_chunk_hash[DM_TRACKED_CHUNK_HASH(chunk)]);

	spin_unlock_irqrestore(&s->tracked_chunk_lock, flags);

	spin_unlock_irq(&s->tracked_chunk_lock);



	return c;

}