Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9a450f9a authored by Malcolm Priestley's avatar Malcolm Priestley Committed by Greg Kroah-Hartman
Browse files

staging: vt6656: s_uCalculateLinkQual use netstats rx values 



Use netstats rx_packets and rx_frame_errors.

Add frame errors to RXbBulkInProcessData

The current scStatistic.RxFcsErrCnt only records
USB errors not frame errors.

The scStatistic.RxOkCnt only recorded successful USB
transfers not actual successfully received packets.

So a more accurate reading is to use netstats rx_packets and
rx_frame_errors.

Signed-off-by: default avatarMalcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 854f775a

drivers/staging/vt6656/bssdb.c

+2 −3
Original line number Diff line number Diff line
@@ -1393,13 +1393,12 @@ static void s_uCalculateLinkQual(struct vnt_private *pDevice) 


	TxCnt = stats->tx_packets + pDevice->wstats.discard.retries;



	RxCnt = pDevice->scStatistic.RxFcsErrCnt +

	      pDevice->scStatistic.RxOkCnt;

	RxCnt = stats->rx_packets + stats->rx_frame_errors;



	TxOkRatio = (TxCnt < 6) ? 4000:((stats->tx_packets * 4000) / TxCnt);



	RxOkRatio = (RxCnt < 6) ? 2000 :

				((pDevice->scStatistic.RxOkCnt * 2000) / RxCnt);

				((stats->rx_packets * 2000) / RxCnt);



	/* decide link quality */

	if (pDevice->bLinkPass != true) {

drivers/staging/vt6656/dpc.c

+3 −0
Original line number Diff line number Diff line
@@ -291,12 +291,14 @@ int RXbBulkInProcessData(struct vnt_private *pDevice, struct vnt_rcb *pRCB, 


	if (BytesToIndicate != FrameSize) {

		DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO"------- WRONG Length 1\n");

		pStats->rx_frame_errors++;

		return false;

	}



    if ((BytesToIndicate > 2372) || (BytesToIndicate <= 40)) {

        // Frame Size error drop this packet.

	DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "---------- WRONG Length 2\n");

	pStats->rx_frame_errors++;

        return false;

    }
@@ -314,6 +316,7 @@ int RXbBulkInProcessData(struct vnt_private *pDevice, struct vnt_rcb *pRCB, 
         (BytesToIndicate < (*pwPLCP_Length)) ) {



        DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO"Wrong PLCP Length %x\n", (int) *pwPLCP_Length);

	pStats->rx_frame_errors++;

        return false;

    }

    for ( ii=RATE_1M;ii<MAX_RATE;ii++) {