Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 999fb23e authored by Jesper Nilsson's avatar Jesper Nilsson
Browse files

CRISv32: Fix typo compile error in ARTPEC-3 gpio driver. 



arch/cris/arch-v32/drivers/mach-a3/gpio.c:
+spin_lock_irqrestore(&gpio_lock, flags);
arch/cris/arch-v32/drivers/mach-a3/gpio.c:
+spin_lock_irqrestore(&gpio_lock, flags);

  should that not be "spin_unlock_irqrestore()"?

The code in question was inside an (most often) undefined ifdef.

Reported-by: default avatar"Robert P. J. Day" <rpjday@crashcourse.ca>
Signed-off-by: default avatarJesper Nilsson <jesper.nilsson@axis.com>
parent 6d3d4be4

arch/cris/arch-v32/drivers/mach-a3/gpio.c

+2 −2
Original line number Diff line number Diff line
@@ -681,7 +681,7 @@ static int virtual_gpio_ioctl(struct file *file, unsigned int cmd, 
		shadow |= ~readl(dir_oe[priv->minor]) |

			(arg & changeable_bits[priv->minor]);

		i2c_write(VIRT_I2C_ADDR, (void *)&shadow, sizeof(shadow));

		spin_lock_irqrestore(&gpio_lock, flags);

		spin_unlock_irqrestore(&gpio_lock, flags);

		break;

	case IO_CLRBITS:

		spin_lock_irqsave(&gpio_lock, flags);
@@ -690,7 +690,7 @@ static int virtual_gpio_ioctl(struct file *file, unsigned int cmd, 
		shadow |= ~readl(dir_oe[priv->minor]) &

			~(arg & changeable_bits[priv->minor]);

		i2c_write(VIRT_I2C_ADDR, (void *)&shadow, sizeof(shadow));

		spin_lock_irqrestore(&gpio_lock, flags);

		spin_unlock_irqrestore(&gpio_lock, flags);

		break;

	case IO_HIGHALARM:

		/* Set alarm when bits with 1 in arg go high. */