Commit 98dcbb90 authored Dec 03, 2016 by Pan Bian Committed by Greg Kroah-Hartman Nov 30, 2017

iio: light: fix improper return value


[ Upstream commit db4e5376d058af8924fafd0520a0942d92538d0e ]

In function cm3232_reg_init(), it returns 0 even if the last call to
i2c_smbus_write_byte_data() returns a negative value (indicates error).
As a result, the return value may be inconsistent with the execution
status, and the caller of cm3232_reg_init() will not be able to detect
the error. This patch fixes the bug.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188641



Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 47d13823

drivers/iio/light/cm3232.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -119,7 +119,7 @@ static int cm3232_reg_init(struct cm3232_chip *chip)
		if (ret < 0)
		dev_err(&chip->client->dev, "Error writing reg_cmd\n");

		return 0;
		return ret;
		}

		/**