Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 986c011d authored by David Daney's avatar David Daney Committed by Thomas Gleixner
Browse files

genirq: Call bus_lock/unlock functions in setup_irq() 



irq_chips that supply .irq_bus_lock/.irq_bus_sync_unlock functions,
expect that the other chip methods will be called inside of calls to
the pair.  If this expectation is not met, things tend to not work.

Make setup_irq() call chip_bus_lock()/chip_bus_sync_unlock() too.

For the vast majority of irq_chips, this will be a NOP as most don't
have these bus lock functions.

[ tglx: No we don't want to call that in __setup_irq(). Way too many
  	error exit pathes. ]

Signed-off-by: default avatarDavid Daney <ddaney@caviumnetworks.com>
LKML-Reference: <1297296265-18680-1-git-send-email-ddaney@caviumnetworks.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 100b33c8

kernel/irq/manage.c

+6 −1
Original line number Diff line number Diff line
@@ -871,9 +871,14 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) 
 */

int setup_irq(unsigned int irq, struct irqaction *act)

{

	int retval;

	struct irq_desc *desc = irq_to_desc(irq);



	return __setup_irq(irq, desc, act);

	chip_bus_lock(desc);

	retval = __setup_irq(irq, desc, act);

	chip_bus_sync_unlock(desc);



	return retval;

}

EXPORT_SYMBOL_GPL(setup_irq);