Commit 986ac4c8 authored Dec 26, 2018 by Wei Yongjun Committed by Greg Kroah-Hartman Feb 23, 2019

hwmon: (lm80) Fix missing unlock on error in set_fan_div()



[ Upstream commit 07bd14ccc3049f9c0147a91a4227a571f981601a ]

Add the missing unlock before return from function set_fan_div()
in the error handling case.

Fixes: c9c63915519b ("hwmon: (lm80) fix a missing check of the status of SMBus read")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent be62fb6c

drivers/hwmon/lm80.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -393,8 +393,10 @@ static ssize_t set_fan_div(struct device dev, struct device_attribute attr,
		}

		rv = lm80_read_value(client, LM80_REG_FANDIV);
		if (rv < 0)
		if (rv < 0) {
		mutex_unlock(&data->update_lock);
		return rv;
		}
		reg = (rv & ~(3 << (2 * (nr + 1))))
		\| (data->fan_div[nr] << (2 * (nr + 1)));
		lm80_write_value(client, LM80_REG_FANDIV, reg);