Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 97fe3401 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

media: cx231xx: fix potential sign-extension overflow on large shift 



[ Upstream commit 32ae592036d7aeaabcccb2b1715373a68639a768 ]

Shifting the u8 value[3] by an int can lead to sign-extension
overflow. For example, if value[3] is 0xff and the shift is 24 then it
is promoted to int and then the top bit is sign-extended so that all
upper 32 bits are set.  Fix this by casting value[3] to a u32 before
the shift.

Detected by CoverityScan, CID#1016522 ("Unintended sign extension")

Fixes: e0d3bafd ("V4L/DVB (10954): Add cx231xx USB driver")

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 53879169

drivers/media/usb/cx231xx/cx231xx-video.c

+1 −1
Original line number Diff line number Diff line
@@ -1389,7 +1389,7 @@ int cx231xx_g_register(struct file *file, void *priv, 
		ret = cx231xx_read_ctrl_reg(dev, VRT_GET_REGISTER,

				(u16)reg->reg, value, 4);

		reg->val = value[0] | value[1] << 8 |

			value[2] << 16 | value[3] << 24;

			value[2] << 16 | (u32)value[3] << 24;

		reg->size = 4;

		break;

	case 1:	/* AFE - read byte */